There is an issue with the program when the user correctly guesses the number. The program should end when the break statement executes in the while loop found in main(), but instead it times out.

import random


def main():
    level = get_level()
    number = generate_random_number(level)

    while True:
        guess = get_guess()

        if check_guess(number, guess) == False:
            continue
        else:
            break


def get_level():
    while True:
        level = input("Level: ")

        try:
            int(level)
        except ValueError:
            continue
        if int(level) <= 0:
            continue
        else:
            return int(level)

def generate_random_number(level):
    number = random.randint(1, level)

    return number

def get_guess():
    while True:
        guess = input("Guess: ")

        try:
            int(guess)
        except ValueError:
            continue
        if int(guess) <= 0:
            continue
        else:
            return int(guess)

def check_guess(number, guess):
    if guess > number:
        print("Too large!")

        return False
    if guess < number:
        print("Too small!")

        return False
    if guess == number:
        print("Just right!")

        return True


main()
  • mvirts@lemmy.world
    9·
    2 days ago

    Maybe try using the idiom:

    if __name__=="__main__":
    main()

    Instead of calling main since the way it’s written now it will always run your code as soon as your module is imported. If the system expects a function named main and calls it, remove your call to main at the end.

  • pixelpop3@programming.dev
    3·
    2 days ago

    Nothing really sticks out. It could also be something about how the automated checker provides input (maybe it expects to not press enter or something and it’s stuck at input()… hard to say)

    I personally would install ruff and run “ruff check yourfile.py” and then later “ruff check --select=ALL yourfile.py” and read about everything it complains about.

    Google the error codes and find the description and discussion of each and why it is complaining, sometimes they’re not a big deal, sometimes they are aha moments. Ruff has a page discussing each warning and error

    https://docs.astral.sh/ruff/rules/

    • pixelpop3@programming.dev
      2·
      2 days ago

      Actually I think it may be your get_entry() code. The try traps all non-numbers and restarts the loop for new entry. So like typing “exit” or an empty string or anything that’s not convertible to a number is being trapped by the raise and sent back for reentry. And anything that is a number can’t hit the break. Just my guess.

      • peckpebble@lemm.ee
        1·
        2 days ago

        I second this! Add a print(“invalid number, try again”) or something to verify and avoid silent failures.

    • milon@lemm.eeOP
      1·
      2 days ago

      It’s for CS50P which uses a customized VS Code. It has an automated code checker which I ran when I was done.

      outputs “Just right!” when guess is correct

      timed out while waiting for program to exit

      • gedhrel@lemmy.world
        7·
        2 days ago

        How is that checker configured?

        It might be doing something like this:

        import student_module
student_module.main()

        and because you’re already invoking main as the module is imported, it’s getting stuck the second time around. Maybe add some indicative print at the entrypoint to your main function.

        Another reply in here has supplied the standard idiom for making a module executable:

        if __name__ == "__main__":
  main()
        • logging_strict@programming.dev
          1·
          9 hours ago

          What duh eh does standard idiom mean?

          In computer programming, a programming idiom, code idiom or simply idiom is a code fragment having a semantic role[1] which recurs frequently across software projects. It often expresses a special feature of a recurring construct in one or more programming languages, frameworks or libraries. This definition is rooted in the linguistic definition of “idiom”.

          https://en.wikipedia.org/wiki/Programming_idiom

          So this term is vague and abstract. Really not a specific term or grouping of related things.

          The actual terminology

          That standard idiom is called, process guard or simply guard. Learn about this term when doing anything involving multiprocessing.

          The if __name__ == “__main__”: guard is important when working with multiprocessing in Python. This prevents the creation of duplicate processes when the module is imported.

          https://labex.io/tutorials/python-how-to-pass-arguments-in-python-multiprocessing-430780

          So it’s totally not for what its being described as. Or that’s an oversimplification with a loss of vital details of it’s actual purpose.

          It could be worse

          When don’t know the name for something, Call it stuff!. Ya know, when really suack at naming things, be unrepentant! Stuff is as bad of a term i could come up with. Means didn’t know how to describe it to accurately relate what it is or does, without being vulgar; out of fear the typos author left an Easter egg which is best left lie.

          Used this term once, for a SQLAlchemy non-request based router implementation, the Session (term already taken) i call SessionStuff. Doesn’t that just scream competence and authoritative implementation?

          What do you do for a job? Urrrh … stuff?

          Regretted immediately and still do. Cuz session seems to have three different contexts / meanings.

          Oh shit! Used the term, stuff. That’s code prefer to not even read. That’s a thing of nightmares that haunts our collective waking moments.

        • milon@lemm.eeOP
          1·
          16 hours ago

          The idiom allowed it to pass the checker’s tests! Thanks for your help!

          • logging_strict@programming.dev
            1·
            8 hours ago

            You picked up an STD from mvirts. That dodgy terminology has been passed on and added to your lexicon.

            South Park suggested the cure for this, eat a banana. Life doesn’t have to make sense, roll with it.

            Quickly taking a shower was oddly never suggested.

      • onlinepersona@programming.devEnglish
        51·
        2 days ago

        Do you know how to use breakpoints? Put one on “Just right!” and then step through it.

        Edit: I just ran the code and it exits properly. It’s probably your customized VS Code . Which command is it using to run your code?

        Anti Commercial-AI license

      • lime!@feddit.nuEnglish
        2·
        2 days ago

        try running the code outside the special editor, just python3 whatever_file_the_code_is_in.py. if it works as it should, then something is wrong with the environment you have been provided.

      • esa@discuss.tchncs.de
        2·
        2 days ago

        It seems to run fine. You should likely as a TA or something as this appears to be something specific to your environment.

    • milon@lemm.eeOP
      1·
      2 days ago

      Was using tabs but I went through it to make sure and seemed to be ok.

      • logging_strict@programming.dev
        1·
        9 hours ago

        Don’t think that’s a literal suggestion.

        More like a subtle way to portray his frustrations having to look through code example with three while(True) loops?

          • esa@discuss.tchncs.de
            1·
            6 hours ago

            At the user level they’re just tools, not programming languages. Python users are generally moving to ruff (and uv) because of ergonomics: It works well and really fast which makes for a smooth experience in-editor. Plus using fewer tools to achieve a similar result is generally desirable.

            And for a complete newbie like someone taking a course, I think there’s no “sticking with” to speak of. Might as well just skip over the tools people are migrating away from and start with the tool people are migrating to.

  • TheFriendlyDickhead@lemm.ee
    22·
    2 days ago

    Cannot see the issue at first glance, but you can try to write “return null” instead of break. That should always exit the function.

    • logging_strict@programming.dev
      1·
      8 hours ago

      Having multiple return statements in one function is a mistake. There shall ever be only one, unless that’s unworkable due to tons of checks.

      Cringe! That’s like watching bad movies for the joy of really really bad movie moments. Watch Dead Snow II THEN Dead Snow I. Both are cringe. Former good cringe later really really bad cringe. Do not watch in chronological order.

      A return statement within a while loop. Is that good or bad cringe?

      Code with multiple return in one function/method screams noob. Especially when its completely unnecessary and avoidable. The return statement in random locations is a close 2nd.

      The return statement in a while loop is just eyebrow raising. Like trying to write cringe, but forgot the threadpool, with GIL enabled, within the while on crack cocaine loop.

    • logging_strict@programming.dev
      1·
      9 hours ago

      or avoid the break all together; coverage hates break and continue.

      is_found = False
while(on crack cocaine):
    if not is_found:
        do something
        is_found = True
    else:  # pragma: no cover
        pass